[wp-trac] [WordPress Trac] #46872: Marry the Bulk Actions and Change Role controls on list tables via Javascript to avoid conflicts in submission when each has a unique selection.

[WordPress Trac]

#46872: Marry the Bulk Actions and Change Role controls on list tables via
Javascript to avoid conflicts in submission when each has a unique
selection.
-------------------------------------------------+-------------------------
 Reporter:  clayray                              |       Owner:
                                                 |  johnbillion
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.7
Component:  Quick/Bulk Edit                      |     Version:  2.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-dev-   |     Focuses:  ui,
  note dev-feedback early                        |  administration
-------------------------------------------------+-------------------------

Comment (by johnbillion):

 This is looking good. In [attachment:"46872.4.diff"] I have:

 * Fixed a PHP syntax error in `wp-admin/network/sites.php`
 * Converted the IIFE into a function that accepts selectors, to remove the
 duplication between the "Bulk actions" and "Change roles" functionality
 * Reverted the removal of `action2` from the `remove_query_arg()` call
 before doing a redirect, just in case a plugin is still doing things with
 `action2`

 I tested this on all screens that contain list tables, on single site and
 Multisite, with JS enabled and disabled. All working nicely.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46872#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform