[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.7
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:
  testing early                                  |
-------------------------------------------------+-------------------------

Comment (by mikeschroder):

 Replying to [comment:23 TimothyBlynJacobs]:
 > I'm not sure if zipping a copy is the right approach here. In my
 experience, most sites that have issues with a partial update failure ( ie
 some files are not copied resulting in a crash ) are due to resources
 timing out during the upgrade process. By taking a zip, this will
 significantly increase the amount of processing that needs to be done
 during the upgrade process and thus may ''increase'' the likelihood of
 failed updates. Further, since this is a fatal error issue, `copy_dir`
 won't return a result and the rollback code won't execute in that case.

 This was brought up in the hosting community channel for discussion and
 testing, but wanted to leave a quick note that this is also my experience.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform