[wp-trac] [WordPress Trac] #52322: Add comment / comment id param to get_comment_time

WordPress Trac noreply at wordpress.org
Sun Feb 28 09:59:55 UTC 2021


#52322: Add comment / comment id param to get_comment_time
--------------------------------------+------------------------------
 Reporter:  spacedmonkey              |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Comments                  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------------

Comment (by SergeyBiryukov):

 Thanks for the patch! Some notes:

 * The new parameter should be added at the end. Adding it after `$format`
 matches `get_comment_date()`, but is not feasible in practice, as it would
 break backward compatibility.
 * The DocBlock should be aligned per the [https://developer.wordpress.org
 /coding-standards/inline-documentation-standards/php/ documentation
 standards] and would also need a [https://developer.wordpress.org/coding-
 standards/inline-documentation-standards/php/#since-section-changelogs
 @since note].
 * `comment_time()` would probably need a similar change for consistency.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52322#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list