[wp-trac] [WordPress Trac] #44314: `user_confirmed_action_email_content` filter run on two different strings

WordPress Trac noreply at wordpress.org
Sat Feb 27 09:46:41 UTC 2021


#44314: `user_confirmed_action_email_content` filter run on two different strings
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  garrett-
                                                 |  eclipse
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.8
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note early                                     |
-------------------------------------------------+-------------------------

Comment (by coffee2code):

 One minor consideration regarding [attachment:"44314.cc.diff"], with
 respect to the formatting of the `@deprecated` lines. Including the word
 "filter" after the `@see`

 e.g. `Use {@see 'user_request_confirmed_email_content'} filter instead.`

 is rarely done in core. There appear to be only 3 instances of it.
 Omitting the word

 e.g. `Use {@see 'user_request_confirmed_email_content'} instead.`

 has 34 existing similar formatting uses, so the convention would be to
 omit it.

 My forthcoming patch will account for this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44314#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list