[wp-trac] [WordPress Trac] #51837: Adding `add_theme_support` for html5 for scripts, does not remove the type attribute from `wp-emoji-release.min.js`

[WordPress Trac]

#51837: Adding `add_theme_support` for html5 for scripts, does not remove the type
attribute from `wp-emoji-release.min.js`
---------------------------+-----------------------------
 Reporter:  kanlukasz      |       Owner:  SergeyBiryukov
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  5.8
Component:  Script Loader  |     Version:  5.3
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-patch => has-patch
 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * milestone:  Awaiting Review => 5.8


Comment:

 Thanks for the patch! I don't think the `emoji_type_attr` filter is needed
 here, just checking `current_theme_supports( 'html5', 'script' )` should
 be enough. Looks good to me otherwise.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51837#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform