[wp-trac] [WordPress Trac] #52257: Twenty Twenty-One:Transparent png logo isn’t visible on focus

WordPress Trac noreply at wordpress.org
Mon Feb 22 23:00:28 UTC 2021


#52257: Twenty Twenty-One:Transparent png logo isn’t visible on focus
------------------------------+-----------------------
 Reporter:  bduclos           |       Owner:  antpb
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  5.7
Component:  Bundled Theme     |     Version:  5.6
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  css
------------------------------+-----------------------

Comment (by ryelle):

 I have another cleanup suggestion — [attachment:"52257.diff"] moves the
 dark mode overrides out of `style-dark-mode.scss` and merges them with the
 dark mode styles in `links.scss`.

 This removes the dark mode's `.custom-logo-link` override, because it's
 not necessary anymore - the dark mode focus style specificity is lower
 now, so it's not overriding the default `background:none;`.

 I also replaced `var(--global--color-background)` with ` var(--global
 --color-white)` in the dark mode meta-nav link styles, since this was just
 being overridden with white later.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52257#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list