[wp-trac] [WordPress Trac] #52610: Consider removing many of the default test group exclusions

WordPress Trac noreply at wordpress.org
Mon Feb 22 20:24:45 UTC 2021


#52610: Consider removing many of the default test group exclusions
--------------------------------------+------------------------------
 Reporter:  johnbillion               |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |     Focuses:  multisite
--------------------------------------+------------------------------

Comment (by jeremyfelt):

 > The ms-files exclusion should be removed too because the tests in the
 ms-files` group don't get registered on a non-Multisite test run so the
 exclusion is redundant.

 Removing the exclusion for `ms-files` from the single site config makes
 sense.

 Via [30286]:

 > When the ms_files_rewriting flag is enabled, ms_upload_constants() is
 required to properly set upload directory constants. Once this fires, it
 is impossible to clean up for a non ms_files_rewriting test by turning the
 option back off.

 I ''think'' this remains a reason to continue excluding `ms-files` in the
 multisite test config.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52610#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list