[wp-trac] [WordPress Trac] #52579: Delete link-manager.zip after running the REST API plugins controller tests
WordPress Trac
noreply at wordpress.org
Sat Feb 20 18:31:50 UTC 2021
#52579: Delete link-manager.zip after running the REST API plugins controller tests
------------------------------+------------------------------
Reporter: johnbillion | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version: 5.5
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
------------------------------+------------------------------
Comment (by TimothyBlynJacobs):
I feel like something regressed here, because I don't think it did this
when it was initially committed. IIRC, `setup_plugin_download` copies the
zip to the alternate location because after the plugin was installed, the
source file was being deleted. I'm not sure why it isn't being deleted
anymore. Looking at the call to `unpack_package` in `WP_Upgrader::run` it
seems like it should be being deleted.
That being said, we could probably add an `unlink` in `tearDown` like
we're currently doing for the test plugin regardless.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52579#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list