[wp-trac] [WordPress Trac] #52576: Message to please install Flashplayer can be retired now

[WordPress Trac]

#52576: Message to please install Flashplayer can be retired now
---------------------------+------------------------------
 Reporter:  tobifjellner   |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Script Loader  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------------------

Comment (by SergeyBiryukov):

 Thanks for the ticket!

 The message comes from the [https://github.com/mediaelement/mediaelement
 MediaElement.js library], the string in [source:tags/5.6.1/src/wp-includes
 /script-loader.php?marks=935#L926 wp-includes/script-loader.php] is just
 to make sure the message can be translated to all the locales that
 WordPress supports.

 While we could remove the message from `script-loader.php`, that would
 mean the message, when still displayed under any circumstances, would
 always be displayed in English.

 From a consistency point of view, I think that as long as that message is
 still a part of MediaElement.js, it makes sense to keep it translatable,
 same as the other strings. When it's no longer a part of the library, it
 will be removed as part of updating to a new version in a ticket like
 #51315.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52576#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform