[wp-trac] [WordPress Trac] #52564: Twenty Twenty has unit-less CSS variable unfit for calc()

WordPress Trac noreply at wordpress.org
Thu Feb 18 20:44:38 UTC 2021


#52564: Twenty Twenty has unit-less CSS variable unfit for calc()
---------------------------+---------------------
 Reporter:  nico23         |       Owner:  ryelle
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  5.7
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |     Focuses:  css
---------------------------+---------------------
Changes (by ryelle):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"50388" 50388]:
 {{{
 #!CommitTicketReference repository="" revision="50388"
 Twenty Twenty-One: Add the px unit to the admin bar height custom
 property.

 The admin bar height custom property is used in `calc` functions, which
 require consistent unit use, even when the value is zero. A unitless value
 returns an invalid value for the "height" property, where this variable is
 used. This also changes the stylelint rule in the theme to allow zero
 values with a unit, just in custom properties.

 Props nico23.
 Fixes #52564.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52564#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list