[wp-trac] [WordPress Trac] #52561: Only run and upload one test run to Codecov
WordPress Trac
noreply at wordpress.org
Thu Feb 18 17:21:53 UTC 2021
#52561: Only run and upload one test run to Codecov
------------------------------+------------------------------
Reporter: johnbillion | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
------------------------------+------------------------------
Comment (by jorbin):
We are using the flags and they are working as expected though the UI in
codecov could lead to some confusion here. I'll use wp_lostpassword_url as
an example for why I think things are working as expected.
By default, all three flags are checked and we can see that line 624 is
covered:
[[Image(https://ucacf470ce8dc58cbe0ad122e7b8.previews.dropboxusercontent.com/p/thumb
/ABEJ0dX3RexN1FGgWjfSeO0XZVWnTMJIdl8Da3pPhaljG2iY3ejk5abSfEC_K235Fe64DN8fis0VGLHbtGVA99PSGioi04zpFUQrDLf7Jxk5S1cyFIxs_fWeCDrEe4625NlovRqHiiJcI5vCnVhmggf6GShpU9vOO7FqIyTnFhP64a16nc6pST8VXFPDBJQftMvXiYrJ3tIpcVONuY_amTVYBGopAHcVQilpC6p9qcMH_1Pq3OCK4oBwzmlSV-
zBAJwOzVDCyfDsTi3xlLm15nmE7KgyzOgqJcS1Ud8PEMVTp2E2CBMCNiHwUkHGuxotF3UUUcUgHmhVOzvqvTEBPWERZwteSMTnn4U-
qgIdhWvi1KE_S-
YY_LclSQwXm7_3g8_1euiJue0u38f7ezN9e2Mf/p.png?fv_content=true&size_mode=5)]]
If only single is selected, then 624 is not covered, but 627 remains
covered:
[[Image(https://uc5f1bd0cf57db3184437bf7e979.previews.dropboxusercontent.com/p/thumb
/ABE9o25zFnCPGDj84zucMeI6vtiI1cxCgk5inaY8JjH4WnqQ48pe9ov8A45KsLBB6VlXgGD8uSTA-
idvfRXOR7Y9QezhkZuRn1shbtOcYV9VxVzzbdS-
fBBV5bw09E4UnXi7e0FrVUnDTvoQClCzzGwat8ZscB__KxIcFuAuqHkrLb8uA5z4tohAHuTfNIjJl3y71QDvdD2HwBw3ETyPc7_zEoIOUjcvmxa8_nn8IAOxd0ZWKzuoz5GmGYWWEE24uPt0Mdzst6_kNOFsMNlR6dsv5Gf7gTI4hKShYeETufLgH3b5CdTjTPTeZ_VtzzMkFWuG1HdtwJvABcIUoGSPldYzKeVOu6dF5CQW1Z79AmNuEPiekrmzVdseO3Rc6f9oKINV49BRMRrCzkJJ4xaCWYrt/p.png?fv_content=true&size_mode=5)]]
If only multisite is selected, then 624 is still covered, but 627 is not.
[[Image(https://uc171d0fa1edc272379c53ce488e.previews.dropboxusercontent.com/p/thumb
/ABHWgNG74VXAUaRadhGYEbQVvUAqiFOZFZqhJPPR7NaU8_I6v8D46G3Kw-s4Qq0dnaB65y-
Omq7kkeIE6EXwijrJdjfGbL2yOIw7MOV7OVRhGBe6dLg6DrIy9dNKUn2KhOOouVwFdonR3nyN4yPj3cp32L1kt49Y2COjHBv-
sB2pbntynmPeEMaQbpV6wxxP_q8i68ZfYkOnSn840cV9k9wkfUjyeqgY1G5IcVX5O7SvL5tn-j
-ZFF8Bxa07rss_z58n-HPzZu-raINWg1_Uobk7EAYz-I22xqKrtU1IOhx3fZQt4EL-
YqB6rCqEqr7tublZckWhfPxkrCQyjJN9Z6atT2TbdQcZpp2F-
rDwG0cgUONG32DJmSNJyn7yueRHaZm_r7qPGGNDUHaF_EH6BYOj/p.png?fv_content=true&size_mode=5)]]
The reason there are three flags is so that when we add E2E tests, we can
see what is covered by php tests and what is covered by e2e tests. I don't
know why there is a 2 in the sidebar when 3 flags should have a line
covered.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52561#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list