[wp-trac] [WordPress Trac] #51660: Adding a filter to WP_List_Table::months_dropdown() to allow overriding the list of months displayed
WordPress Trac
noreply at wordpress.org
Tue Feb 16 19:46:08 UTC 2021
#51660: Adding a filter to WP_List_Table::months_dropdown() to allow overriding the
list of months displayed
---------------------------------------------+-----------------------------
Reporter: geoffguillain | Owner: SergeyBiryukov
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 5.7
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-dev-note commit | Focuses: performance
---------------------------------------------+-----------------------------
Comment (by SergeyBiryukov):
Replying to [comment:26 SergeyBiryukov]:
> Replying to [comment:25 TimothyBlynJacobs]:
> > I'm not strongly opposed. But the reason I recommended it behave this
way is that the vast majority of core `pre_` short-circuit filters I saw
did not have their "standard" filter applied.
>
> Ah, good point. At a glance, there are some that immediately return
without any other filters applied, and some that just short-circuit the
query or heavy processing and continue to other filters. I can circle back
after a closer review.
I still don't have a full list at this point, but the
`pre_months_dropdown_query` filter seems closer to the latter pattern
(also used by the `pre_move_uploaded_file` filter, for example), so I
think [attachment:"51660.diff"] would be preferred here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51660#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list