[wp-trac] [WordPress Trac] #26350: !important audit

[WordPress Trac]

#26350: !important audit
----------------------------+-----------------------------------
 Reporter:  azaozz          |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  high            |   Milestone:  5.8
Component:  Administration  |     Version:  3.8
 Severity:  major           |  Resolution:
 Keywords:  needs-patch     |     Focuses:  ui, css, performance
----------------------------+-----------------------------------
Changes (by sabernhardt):

 * milestone:  5.7 => 5.8


Comment:

 @dingo_d Could you create a GitHub issue for the custom icons (or should
 I)? The `!important` had been necessary to change the style when those
 buttons are in the disabled state. GB16349 added a gray background color
 and then GB16390 removed it.
 -
 [https://github.com/WordPress/gutenberg/commit/ef73ed07bd59bdcbbe77cc1c537299d8e39167b1
 #diff-
 52080888cb9d45c4ec38e7c9ecaca9dfd685f8c985376625cca7191e45ab0908R50-R61
 GB16390 was part of the G2 update]
 -
 [https://github.com/WordPress/gutenberg/blob/2475a366cf1dbc2e7ffa347de8eba5624c180a88/packages
 /block-editor/src/components/block-switcher/style.scss#L50 current block-
 switcher/style.scss file]

 Milestone edited to 5.8 for creating any patches after the audit conducted
 during 5.7.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/26350#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform