[wp-trac] [WordPress Trac] #51340: Stop chmodding files and folders

[WordPress Trac]

#51340: Stop chmodding files and folders
----------------------------+------------------------------
 Reporter:  malthert        |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Filesystem API  |     Version:  5.3
 Severity:  major           |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------------------
Changes (by SergeyBiryukov):

 * version:  5.6.1 => 5.3


Comment:

 Replying to [comment:4 l3rady]:
 > This is done in many areas of the WP codebase but has been missed here.
 I'm not sure at what version this was introduced but I can see the error
 back in WordPress 5.3 but don't see it in WP 4.9 so was introduced at some
 point between them.

 It looks like the error suppression for `chmod()` was intentionally
 removed in [45611] / #47632 per the coding standards, setting the version
 accordingly.

 Could you share the exact error message? There are at least 10 instances
 of `chmod()` in core, so it's not quite clear yet whether the ticket
 applies to the one in `WP_Filesystem_Direct` or any others too.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51340#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform