[wp-trac] [WordPress Trac] #52482: Tests: Reduce usage of assertEquals() for 5.8

WordPress Trac noreply at wordpress.org
Wed Feb 10 08:23:01 UTC 2021


#52482: Tests: Reduce usage of assertEquals() for 5.8
-----------------------------------+---------------------
 Reporter:  johnbillion            |       Owner:  (none)
     Type:  task (blessed)         |      Status:  new
 Priority:  normal                 |   Milestone:  5.8
Component:  Build/Test Tools       |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  needs-unit-tests php8  |     Focuses:
-----------------------------------+---------------------

Comment (by jrf):

 > I've updated the examples in Writing PHPUnit Tests to use assertSame()

 👍

 > Would it be appropriate to add an automated check for this...

 Those are in the making (PHPUnitQA PHPCS standard), but it may still quite
 be a while before there is a ready-to-use release.
 In the mean time, for at least some parts of this, feel free to ping me
 either with ideas for scans to add or to check if I have a scan available
 & for me to post the results somewhere.

 > or at least recommend using assertSame() in the core contributor
 handbook

 Sounds like a good idea.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52482#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list