[wp-trac] [WordPress Trac] #38266: Tests: Use assertSame() when the type of the value in the assertion is important
WordPress Trac
noreply at wordpress.org
Tue Feb 9 21:10:43 UTC 2021
#38266: Tests: Use assertSame() when the type of the value in the assertion is
important
-----------------------------------+-----------------------------
Reporter: johnbillion | Owner: SergeyBiryukov
Type: task (blessed) | Status: closed
Priority: normal | Milestone: 5.7
Component: Build/Test Tools | Version:
Severity: normal | Resolution: fixed
Keywords: needs-unit-tests php8 | Focuses:
-----------------------------------+-----------------------------
Changes (by johnbillion):
* status: accepted => closed
* resolution: => fixed
Comment:
This feels like an ongoing ticket. There's more than 700 instances of
`assertEquals` in use and quite a few of those are still checking falsey
values.
Closing as fixed for 5.7, I'll open a follow-up for 5.8.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38266#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list