[wp-trac] [WordPress Trac] #44314: `user_confirmed_action_email_content` filter run on two different strings

[WordPress Trac]

#44314: `user_confirmed_action_email_content` filter run on two different strings
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  garrett-
                                                 |  eclipse
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.7
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:
  note needs-refresh                             |
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch has-unit-tests needs-dev-note commit => has-patch
     has-unit-tests needs-dev-note needs-refresh


Comment:

 @antpb

 Upon a visual review of [attachment:"44314.7.diff"] :

 * deprecated filters are showing `5.6` rather than `5.7`.
 * CS Nit: Param docblocks not aligned for
 `user_request_action_email_content`
 * Typically the deprecated filters don't have an `@ignore` tag (it seems
 the description is often cut back to `use the [filter] filter instead`.

 Otherwise it looks good.

 In 5.6 this was tagged early and the commit keyword has been sitting on it
 throughout the 5.7 milestone. Is it time to move this to 5.8? If so, my
 first bullet point is out of date ;)

 I've removed the commit keyword and added needs refresh, even though the
 changes are minor.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44314#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform