[wp-trac] [WordPress Trac] #52440: "Leave site? Changes you made may not be saved" on custom taxonomy pages after WP 5.6.1 update

WordPress Trac noreply at wordpress.org
Fri Feb 5 22:36:42 UTC 2021


#52440: "Leave site? Changes you made may not be saved" on custom taxonomy pages
after WP 5.6.1 update
---------------------------------------+-----------------------------
 Reporter:  archon810                  |       Owner:  SergeyBiryukov
     Type:  defect (bug)               |      Status:  reviewing
 Priority:  high                       |   Milestone:  5.6.2
Component:  Editor                     |     Version:  5.6.1
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing


Comment:

 Replying to [comment:21 Clorith]:
 > Replying to [comment:20 mukesh27]:
 > > [https://github.com/WordPress/wordpress-develop/pull/978 PR #978]
 added as per @hwk-fr solution.
 >
 > This looks like a much cleaner approach, checks that the element exists,
 if not uses an empty string as fallback; 👍 from me

 Yeah, this does work as expected in my testing.

 Some notes on testing:
 * Use the classic editor, either via the plugin or a filter:
 {{{
 add_filter( 'use_block_editor_for_post_type', '__return_false' );
 }}}
 * Open a page for editing, wait for the editor to complete loading.
 * Without making any changes, attempt to reload or navigate away from the
 page.
 * You'll see the "Changes you made may not be saved" dialog.
 * The issue only happens on Pages (as they don't have an Excerpt field by
 default), or any custom post types that don't have a Title, Content, or
 Excerpt field.
 * The issue happens both in 5.7 trunk and 5.6.1.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52440#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list