[wp-trac] [WordPress Trac] #52086: user-profile.min.js issue on Firefox

[WordPress Trac]

#52086: user-profile.min.js issue on Firefox
--------------------------+-----------------------------------------
 Reporter:  adi64bit      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.6.2
Component:  Users         |     Version:  5.6
 Severity:  critical      |  Resolution:
 Keywords:                |     Focuses:  javascript, administration
--------------------------+-----------------------------------------

Comment (by jadpm):

 We are experiencing the same problem especialy when using one of our pro
 plugins. We managed to minimize (although not remove) this by movin gone
 script to be enqueued in the footer, but the error is somehow erratic and
 happens from time to time anyway.

 If this helps someone, the script we moved to the footer loads a bunch on
 underscore templates and relies on jQuery UI dialogs for a lot of things,
 but I doubt this is really relevant.

 IMHO, the problem here is in any case the flawed logic for user-profile.js
 around the generatePassword function. It simply assumes that by the time
 zxcvbnis defined then $toggleButton will also be defined, which seems to
 be risky.

 As stated above, a minimal change would be defining $toggleButton before
 we might try to use it on bindPass1().

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52086#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform