[wp-trac] [WordPress Trac] #52441: Fix wp.i18n.isRTL() returning false in RTL languages
WordPress Trac
noreply at wordpress.org
Thu Feb 4 23:30:07 UTC 2021
#52441: Fix wp.i18n.isRTL() returning false in RTL languages
--------------------------------------+-------------------------
Reporter: noisysocks | Owner: noisysocks
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.7
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-------------------------
Comment (by noisysocks):
Thanks for testing!
> This does seem like more of a workaround to me, I understand the
solution to https://core.trac.wordpress.org/ticket/46089 is complex but
I'd really like to see a solution for that. This has the limitation that
it still doesn't add wp-i18n translations, it just adds a specific
translation that we know is required.
Looking at the source for for `wp-i18n`, it seems that `"ltr"` is the only
localised string that that module has. I agree that this is hacky, but is
making `print_translations` treat `wp-i18n` specially any less hacky? Both
solutions feel not ideal to me...
Really I am thinking that `wp-i18n` should not have any localised strings
at all. It doesn't make intuitive sense to me that a module which is used
to implement localisation should require localisation. I wonder if there's
another way of implementing `isRTL`?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/52441#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list