[wp-trac] [WordPress Trac] #52421: Remove admin and login exceptions for https in home_url

WordPress Trac noreply at wordpress.org
Tue Feb 2 20:34:25 UTC 2021


#52421: Remove admin and login exceptions for https in home_url
--------------------------+-----------------------------
 Reporter:  herregroen    |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  5.7
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch needs-refresh => has-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This has introduced two other failures:
 {{{
 1)
 Tests_WP_Resource_Hints::test_dns_prefetch_scripts_does_not_included_registered_only
 Undefined index: pagenow

 /var/www/build/wp-includes/functions.wp-scripts.php:272
 /var/www/tests/phpunit/tests/general/resourceHints.php:192

 2) Tests_WP_Resource_Hints::test_deregistered_scripts_are_ignored
 Undefined index: pagenow

 /var/www/build/wp-includes/functions.wp-scripts.php:272
 /var/www/tests/phpunit/tests/general/resourceHints.php:205
 }}}

 Restoring the `$pagenow` global appears to fix them. It's not quite clear
 why that happens, as the global is no longer used in the function, but
 let's address the failures for now and investigate later.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52421#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list