[wp-trac] [WordPress Trac] #49889: Image.php - Wrap Error Suppressors in WP_DEBUG Conditionals

WordPress Trac noreply at wordpress.org
Tue Feb 2 16:51:32 UTC 2021


#49889: Image.php - Wrap Error Suppressors in WP_DEBUG Conditionals
---------------------------------------------+-----------------------------
 Reporter:  Howdy_McGee                      |       Owner:  SergeyBiryukov
     Type:  enhancement                      |      Status:  closed
 Priority:  normal                           |   Milestone:  5.7
Component:  Media                            |     Version:
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch needs-dev-note commit  |     Focuses:  coding-
                                             |  standards
---------------------------------------------+-----------------------------
Changes (by antpb):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"50146" 50146]:
 {{{
 #!CommitTicketReference repository="" revision="50146"
 Media: Avoid suppressing errors when using `getimagesize()`.

 Previously, all logic utilizing `getimagesize()` was supressing errors
 making it difficult to debug usage of the function.

 A new `wp_getimagesize()` function has been added to allow the errors to
 no longer be suppressed when `WP_DEBUG` is enabled.

 Props Howdy_McGee, SergeyBiryukov, mukesh27, davidbaumwald, noisysocks,
 hellofromTonya.
 Fixes #49889.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49889#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list