[wp-trac] [WordPress Trac] #43697: Add theme update counter in admin theme menu item

WordPress Trac noreply at wordpress.org
Tue Feb 2 16:05:41 UTC 2021


#43697: Add theme update counter in admin theme menu item
---------------------------------------+---------------------------------
 Reporter:  mukesh27                   |       Owner:  (none)
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Themes                     |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, administration
---------------------------------------+---------------------------------
Changes (by zodiac1978):

 * focuses:  administration => ui, administration


Comment:

 @joyously I think using `update-plugins` as class name is not very
 intuitive, but at the moment correct.

 The network menu is using it too:
 https://github.com/WordPress/WordPress/blob/b3b8942dfcb451eddb5559b63c1043fce5d9449e
 /wp-admin/network/menu.php#L65

 We could either use it here too or add the class name to the CSS, because
 at the moment it does not exist:
 https://github.com/WordPress/WordPress/search?q=update-themes

 @mukesh27 Looking at the patch and the screenshot it shows an inconsistent
 behavior: The badge is added to the first submenu item instead of the main
 menu item ("Appearance"), like it is seen for the "Plugins" menu item.

 I would vote for using the same design as for Plugins (which is also used
 in a multisite):
 https://github.com/WordPress/WordPress/blob/b3b8942dfcb451eddb5559b63c1043fce5d9449e
 /wp-admin/network/menu.php#L59-L79

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43697#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list