[wp-trac] [WordPress Trac] #52421: Remove admin and login exceptions for https in home_url

[WordPress Trac]

#52421: Remove admin and login exceptions for https in home_url
-------------------------------------+-----------------------------
 Reporter:  herregroen               |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.7
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Thanks for the patch! It looks like there are some failing tests with this
 change that needs updating:
 {{{
 1) Tests_REST_API::test_rest_url_scheme
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -'http'
 +'https'

 S:\home\wordpress.test\develop\tests\phpunit\tests\rest-api.php:792

 2) Tests_URL::test_home_url_from_admin
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -'http://example.org'
 +'https://example.org'

 S:\home\wordpress.test\develop\tests\phpunit\tests\url.php:210

 3) Tests_URL::test_network_home_url_from_admin
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -'http://example.org'
 +'https://example.org'

 S:\home\wordpress.test\develop\tests\phpunit\tests\url.php:259
 }}}

 Working on that now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52421#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform