[wp-trac] [WordPress Trac] #36982: Add image attributes and additional context to the wp_calculate_image_srcset and wp_calculate_image_sizes filters

WordPress Trac noreply at wordpress.org
Tue Feb 2 04:32:35 UTC 2021


#36982: Add image attributes and additional context to the
wp_calculate_image_srcset and wp_calculate_image_sizes filters
-------------------------------------------------+-------------------------
 Reporter:  kylereicks                           |       Owner:
                                                 |  adamsilverstein
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.7
Component:  Media                                |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion has-unit-      |     Focuses:  template
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by antpb):

 I think the PR is false green because the changes are different from the
 uploaded patch.

 I'm seeing test failures locally around undefined $image_attr attributes.
 Going to investigate fixing these on my end.

 example failure
 `57) Tests_XMLRPC_wp_newPost::test_post_thumbnail Undefined variable:
 image_attr`

 I suspect it's a quick find/replace sort of fix for these tests.

 Would appreciate a review before commit!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/36982#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list