[wp-trac] [WordPress Trac] #52148: CSS Optimization: Use shorthand 'border' value in wp-admin/css/admin-menu.css

WordPress Trac noreply at wordpress.org
Mon Feb 1 19:23:06 UTC 2021


#52148: CSS Optimization: Use shorthand 'border' value in wp-admin/css/admin-
menu.css
----------------------------------+----------------------------------------
 Reporter:  ankitmaru             |       Owner:  SergeyBiryukov
     Type:  enhancement           |      Status:  reviewing
 Priority:  normal                |   Milestone:  5.7
Component:  Administration        |     Version:  trunk
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-      |     Focuses:  ui, css, coding-standards
  refresh                         |
----------------------------------+----------------------------------------

Comment (by sabernhardt):

 The styles for `#customize-theme-controls .add-new-menu-item` do not need
 the `px` units for the three zero values, because the result is the same
 no matter what the unit is.
 {{{
 #customize-theme-controls .add-new-widget,
 #customize-theme-controls .add-new-menu-item {
         cursor: pointer;
         float: right;
         margin: 0 0 0 10px;
         transition: all 0.2s;
         -webkit-user-select: none;
         -ms-user-select: none;
         user-select: none;
         outline: none;
 }
 }}}

 (You already did similarly with the `body.cheatin h1` padding earlier in
 that file.)
 {{{
 padding: 0 0 7px;
 }}}

 Also, I don't think the class-wp-comments-list-table.php change belongs on
 this ticket. After putting the `@global int $post_id` first among the
 global variables, you could upload a patch for that file to ticket:51800.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52148#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list