[wp-trac] [WordPress Trac] #34281: Allow admins to send users a 'Reset Password' link

[WordPress Trac]

#34281: Allow admins to send users a 'Reset Password' link
-------------------------------------------------+-------------------------
 Reporter:  Ipstenu                              |       Owner:
                                                 |  adamsilverstein
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Users                                |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-ux-feedback      |     Focuses:  javascript
  has-patch                                      |
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 @johnbillion Excellent, thanks for reviewing.


 > Removed the formatting-only changes (mostly == to ===) that aren't
 related to the functional change, these should happen in a separate ticket
 so they can be checked properly.

 Thanks. I had changed these to assuage the linter, better to leave them
 out!

 > Adjusted the formatting of retrieve_password() to minimise the non-
 functional changes and make it easier to see the diff from its old
 version. Below is the actual diff.

 Super, thanks for providing that and reformatting.

 > There are two noticeable changes to retrieve_password() as a result.
 These appear to create a functional change that might not be expected. The
 two sanitize_*() functions both strip octets and entities, for example.
 @adamsilverstein what's the reason to switching to using these functions?

 This looks like a mistake, likely from, the original patch work which we
 have studiously brought forward. I will revert these changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/34281#comment:74>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform