[wp-trac] [WordPress Trac] #54708: Improve `_set_preview` for case when autosave missing

WordPress Trac noreply at wordpress.org
Wed Dec 29 21:35:57 UTC 2021


#54708: Improve `_set_preview` for case when autosave missing
------------------------------------------------+--------------------------
 Reporter:  adamsilverstein                     |       Owner:
                                                |  adamsilverstein
     Type:  defect (bug)                        |      Status:  assigned
 Priority:  normal                              |   Milestone:  5.9
Component:  General                             |     Version:  trunk
 Severity:  normal                              |  Resolution:
 Keywords:  dev-feedback has-patch 2nd-opinion  |     Focuses:
------------------------------------------------+--------------------------
Changes (by adamsilverstein):

 * version:   => trunk
 * milestone:  Awaiting Review => 5.9


Comment:

 Marking this for 5.9 since it corrects a pretty serious regression where
 featured images no longer show consistently in previews for block themes.
 Alternately we could land after release and backport in the first "point"
 release. I would appreciate a 2nd committer opinion here.

 This problem has actually existed for as long as the autosave endpoint,
 and back in 2018 we added an extra query variable to previews in Gutenberg
 just to work around the issue (see
 https://github.com/WordPress/gutenberg/issues/9151).

 The block theme featured image rendering surfaced this bug again, fixing
 it in core makes more sense though, this also fixes term filtering for
 previews which would also break when autosaves are missing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54708#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list