[wp-trac] [WordPress Trac] #54690: Add ability to filter whole notification email in retrieve_password

[WordPress Trac]

#54690: Add ability to filter whole notification email in retrieve_password
----------------------------------------+---------------------
 Reporter:  connapptivity               |       Owner:  (none)
     Type:  feature request             |      Status:  new
 Priority:  normal                      |   Milestone:  6.0
Component:  Users                       |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+---------------------
Changes (by costdev):

 * keywords:  has-patch => has-patch needs-unit-tests
 * milestone:  Awaiting Review => 6.0


Comment:

 Hi @connapptivity, welcome to Trac! Thanks for suggesting this new filter
 and submitting a PR! I have left a couple of suggestions in an initial
 review.

 I can appreciate that making changes to individual parts of the email can
 be frustrating. For this reason, and for consistency with
 `wp_password_change_notification()`, I think that adding this all-
 encompassing filter is a good idea!

 For now, I'm going to Milestone this for 6.0.

 The `retrieve_password()` function doesn't appear to have any unit tests.
 This would be a perfect opportunity to start some. I'm going to add the
 `needs-unit-tests` keyword in case anyone on the Test team wants to take a
 look at this.

 You are also welcome to write the unit tests yourself, of course - see the
 [https://make.wordpress.org/core/handbook/testing/automated-testing
 /writing-phpunit-tests/ Writing PHP Tests] page if you're unfamiliar with
 this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54690#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform