[wp-trac] [WordPress Trac] #46600: Twenty Nineteen: Flex order on comment form causes contents of comment_form_after to appear above the form

WordPress Trac noreply at wordpress.org
Thu Dec 23 20:02:02 UTC 2021


#46600: Twenty Nineteen: Flex order on comment form causes contents of
comment_form_after to appear above the form
-----------------------------+---------------------------------
 Reporter:  garrett-eclipse  |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  6.0
Component:  Bundled Theme    |     Version:  5.0
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  accessibility, css
-----------------------------+---------------------------------
Changes (by sabernhardt):

 * keywords:  needs-patch => has-patch
 * milestone:  Future Release => 6.0


Comment:

 Adding a message also hides the "Leave a comment" heading, and
 [attachment:"46600.diff"] shows it again.

 The patch uses a new class to stop using CSS flex, but any child theme
 with the old markup still would have those styles. And this new container
 is hidden in the print stylesheet.

 The patch does not match the styles perfectly when no messages are added.
 The 1rem top margin for the short line above the heading does not apply
 (it's included in the wrapper's margin), though I'm not convinced that the
 extra space is necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46600#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list