[wp-trac] [WordPress Trac] #54382: Finalise the Theme Editor admin menu item placement

WordPress Trac noreply at wordpress.org
Tue Dec 21 19:35:03 UTC 2021


#54382: Finalise the Theme Editor admin menu item placement
-------------------------------------------------+-------------------------
 Reporter:  poena                                |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  5.9
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-docs needs-dev-note  |     Focuses:  ui
  commit i18n-change                             |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch needs-docs needs-dev-note => has-patch needs-docs
     needs-dev-note commit i18n-change


Comment:

 = Test Report

 Env:
 * OS: macOS Big Sur
 * Browser: Edge, Chrome, Firefox, Safari
 * Plugins: None
 * Theme: TT1 and then TT2
 * Localhost: wp-env

 == Steps

 1. Pull down and apply [https://github.com/WordPress/wordpress-
 develop/pull/1948 PR 1948]
 2. Go to Appearance > Themes
 3. Activate Twenty Twenty-One (TT1) theme
 Expected behavior:
     * Under Appearance, the "Theme Editor" menu item is renamed to "Theme
 File Editor".
     * Under Plugins, the "Plugin Editor" menu item is renamed to "Plugin
 File Editor".
     * Neither of these file editors appear in Tools.
 4. Activate Twenty Twenty-Two (TT2) theme
 Expected behavior:
     * Under Appearance, the "Theme Editor" menu item does not appear.
     * Under Plugins, the "Plugin Editor" menu item does not appear.
     * Under Tools, the "Theme File Editor" and "Plugin File Editor" menu
 items are present.

 == Results

 * With TT1 (or any non-theme.json theme), the theme/plugin editor menus
 are retained in their original locations and are renamed ✅
 * With TT2, the theme/plugin editor menus are relocated to Tools and are
 renamed ✅

 Marking [https://github.com/WordPress/wordpress-develop/pull/1948 PR 1948]
 for commit and adding the `i18n-change` keyword for the late string
 changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54382#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list