[wp-trac] [WordPress Trac] #53658: Display a user-facing message when the application passwords functionality is not available

WordPress Trac noreply at wordpress.org
Mon Dec 20 20:59:22 UTC 2021


#53658: Display a user-facing message when the application passwords functionality
is not available
-------------------------------------------------+-------------------------
 Reporter:  johnbillion                          |       Owner:
                                                 |  johnbillion
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Application Passwords                |     Version:  5.6
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch has-unit-   |     Focuses:
  tests commit                                   |  administration
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  good-first-bug has-patch has-unit-tests => good-first-bug has-
     patch has-unit-tests commit


Comment:

 = Test Report

 Env:
 * OS: macOS Big Sur
 * Browser: Chrome and Edge
 * Localhost: Local and wp-env
 * Plugins: none
 * Theme: TT2

 == Steps

 1. Pull latest `trunk`.
 2. Add a must-use file by creating a folder under `wp-content/mu-plugins`
 and then adding `wp-content/mu-plugins/test53658.php` file.
 3. Add the following code to the test file:
 {{{#!php
 <?php

 add_filter( 'wp_is_application_passwords_available', '__return_false' );
 }}}
 4. Enable HTTPS on your test site.
 5. Navigate to your user profile in Users > Profile.
 6. Scroll down to "Application Passwords" section.
 Notice the error message that HTTPS is needed:
 {{{
 The application password feature requires HTTPS, which is not enabled on
 this site.
 }}}

 7. Applying [https://github.com/WordPress/wordpress-develop/pull/2069 PR
 2069] patch.
 8. Refresh the page.
 Expected behavior: The "Application Passwords" section is gone.

 9. Comment out the `add_filter` code in the test file.
 Expected behavior: The "Application Passwords" section displays and
 there's no message about needing HTTPS.

 == Results

 * At Step 6: Able to reproduce the reported issue ✅
 * At Step 7-8: The application passwords section is gone and no error ✅
 * At Step 9: The application passwords section displays properly and no
 error ✅

 [https://github.com/WordPress/wordpress-develop/pull/2069 PR 2069]
 resolves the reported issue in [#comment:11 comment 11 above].

 Marking it for commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53658#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list