[wp-trac] [WordPress Trac] #54638: Incorrect use of _n() in new strings for 5.9

WordPress Trac noreply at wordpress.org
Thu Dec 16 23:49:19 UTC 2021

#54638: Incorrect use of _n() in new strings for 5.9
 Reporter:  tobifjellner  |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Editor        |    Version:  trunk
 Severity:  major         |   Keywords:
  Focuses:                |
 The new code for WordPress contains three instances where the "Template
 Part"/"Template Parts" string pair is used.

 However, this is usage of _n() is incorrect.
 If you want to handle just the singular and plural terms, then this should
 be handled in the code (if 1 == n then ...) and not by using _n()

 Alternatively, if these strings are used together with the relevant
 number, then a placeholder for the count variable should be present in the
 string (i.e. printf)

 Three references (to the current as-built package)

   const entityLabel = name === 'wp_template_part' ?
 Object(external_wp_i18n_["_n"])('Template Part', 'Template Parts',
 list.length) : entity.label; // Set description based on type of entity.



Ticket URL: <https://core.trac.wordpress.org/ticket/54638>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list