[wp-trac] [WordPress Trac] #53516: Add unit tests for `WP_REST_Server->add_site_logo_to_index()`.

WordPress Trac noreply at wordpress.org
Wed Dec 15 18:06:29 UTC 2021


#53516: Add unit tests for `WP_REST_Server->add_site_logo_to_index()`.
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  5.9
Component:  REST API                             |     Version:  5.8
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  good-first-bug has-patch has-unit-   |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"52381" 52381]:
 {{{
 #!CommitTicketReference repository="" revision="52381"
 Tests: Add an assertion to test the
 `WP_REST_Server::add_site_logo_to_index()` method.

 Additionally:
 * Move the test for `WP_REST_Server::add_active_theme_link_to_index()` to
 a more logical place.
 * Replace `assertEquals()` with `assertSame()` in site icon test to also
 check the type of the value.
 * Use a more consistent pattern for the tests.

 Follow-up to [51241], [52080].

 Props ignatggeorgiev, desrosj, SergeyBiryukov.
 Fixes #53516. See #53363.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53516#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list