[wp-trac] [WordPress Trac] #54517: The naming of some of the WP_Theme_JSON_Resolver's methods is not optimal

[WordPress Trac]

#54517: The naming of some of the WP_Theme_JSON_Resolver's methods is not optimal
------------------------------+----------------------------
 Reporter:  antonvlasenko     |       Owner:  antonvlasenko
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.9
Component:  Themes            |     Version:  trunk
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  rest-api
------------------------------+----------------------------
Changes (by hellofromTonya):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"52372" 52372]:
 {{{
 #!CommitTicketReference repository="" revision="52372"
 Themes: Rename public static functions in `WP_Theme_JSON_Resolver` to
 remove `custom_post_type` references.

 WordPress Core is not really custom and does not reference "custom post
 type" in its function naming. This commit renames 2 public static methods:

 * `WP_Theme_JSON_Resolver::get_user_custom_post_type_id()` renamed to
 `WP_Theme_JSON_Resolver::get_user_global_styles_post_id()`.
 * `WP_Theme_JSON_Resolver::get_user_data_from_custom_post_type()` renamed
 to `WP_Theme_JSON_Resolver:: get_user_data_from_wp_global_styles()`.

 Follow-up to [52049], [52051], [52069], [52232], [52275], [52364].

 Props antonvlasenko, bernhard-reiter, costdev, desrosj, hellofromTonya,
 noisysocks, oandregal, SergeyBiryukov.
 Fixes #54517.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54517#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform