[wp-trac] [WordPress Trac] #54160: sanitize_key() / _wp_customize_include() is not able to handle non-scalar values

WordPress Trac noreply at wordpress.org
Fri Dec 10 21:26:57 UTC 2021


#54160: sanitize_key() / _wp_customize_include() is not able to handle non-scalar
values
----------------------------------------+-----------------------------
 Reporter:  dd32                        |       Owner:  hellofromTonya
     Type:  defect (bug)                |      Status:  reopened
 Priority:  normal                      |   Milestone:  6.0
Component:  Formatting                  |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------------

Comment (by wppunk):

 @hellofromTonya It shouldn't work in this way if this code worked for the
 int, float, bool types. That means the documentation was incorrect.

 If you want to change this behavior and support only string values:
 - Firstly, show a deprecation message and support undocumented variables.
 - A few releases later, it is possible to remove support undocumented
 types.

 Why do I insist on this? Because this bug is floating, it is pretty
 challenging to find this floating bug. For example, in my code, all
 checkboxes are deleted after saving. Let's come up with a blueprint for a
 smooth deprecation process.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54160#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list