[wp-trac] [WordPress Trac] #54552: Consider consolidating wp_is_block_template_theme() and WP_Theme::is_block_based()

[WordPress Trac]

#54552: Consider consolidating wp_is_block_template_theme() and
WP_Theme::is_block_based()
------------------------------+-----------------------------
 Reporter:  noisysocks        |       Owner:  hellofromTonya
     Type:  task (blessed)    |      Status:  closed
 Priority:  normal            |   Milestone:  5.9
Component:  Themes            |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------
Changes (by hellofromTonya):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"52330" 52330]:
 Themes: Better names for `WP_Theme::is_block_theme()` and
 `wp_is_block_theme()` and make `wp_is_block_theme()` a wrapper.

 This commit renames the following method and function to better represent
 block theme terminology:

 * `WP_Theme::is_block_based()` to `WP_Theme::is_block_theme()`
 * `wp_is_block_template_theme()` to `wp_is_block_theme()`

 It also changes `wp_is_block_theme()` to be a helper wrapper (sugar
 syntax) for `wp_get_theme()->is_block_theme();`. Why? To ensure both the
 method and function behave the same, to help Gutenberg maintain WordPress
 cross-version compatibility, and to make it less cumbersome to port
 changes from Gutenberg to Core.

 Follow-up to [52069], [52247], [52279].

 Props antonvlasenko, costdev, hellofromTonya, noisysocks.
 Fixes #54550.

 Note: I made an error and the `Fixes` should have been this ticket.
 :facepalm:

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54552#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform