[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

WordPress Trac noreply at wordpress.org
Tue Dec 7 00:17:48 UTC 2021

#54504: Update Requests library to version 2.0.0
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.0
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early          |

Comment (by azaozz):

 Replying to [comment:35 jrf]:
 > The namespacing in Requests 2.0.0 and the file renames are NOT a BC-

 Yeah, I know. Sorry about it. Best to move the conversation to another
 place, perhaps at https://make.wordpress.org/core/.

 > Now back to the problem at hand: what's breaking here is not Requests
 2.0.0. What's breaking is that the WP upgrader process is trying to use a
 mix of files from Requests 1.x and 2.x during the upgrade process and
 isn't equipped to handle case-only file renames.
 > Am I surprised that that breaks things ? No, as that's a very clear bug
 and code smell. But it's a bug in the upgrader, not in Requests.

 I understand that, but on the other hand files in WordPress should never
 be renamed unless absolutely unavoidable. If this triggers a but in WP are
 there a 100% guarantee it will never trigger a bug somewhere else?

 As this is a WordPress (sub) project, I'd think it should follow the
 established rules/best practices. So the questing is: is this completely
 unavoidable? If not, I stand by my recommendation to revert and release a
 new version before merging to WP.

Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list