[wp-trac] [WordPress Trac] #54550: The margin added at the top level styles (for body) in theme.json is override by a margin added from Gutenberg

WordPress Trac noreply at wordpress.org
Tue Dec 7 00:00:59 UTC 2021


#54550: The margin added at the top level styles (for body) in theme.json is
override by a margin added from Gutenberg
------------------------------+-----------------------------
 Reporter:  get_dave          |       Owner:  hellofromTonya
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.9
Component:  General           |     Version:  trunk
 Severity:  minor             |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------

Comment (by hellofromTonya):

 In [changeset:"52330" 52330]:
 {{{
 #!CommitTicketReference repository="" revision="52330"
 Themes: Better names for `WP_Theme::is_block_theme()` and
 `wp_is_block_theme()` and make `wp_is_block_theme()` a wrapper.

 This commit renames the following method and function to better represent
 block theme terminology:

 * `WP_Theme::is_block_based()` to `WP_Theme::is_block_theme()`
 * `wp_is_block_template_theme()` to `wp_is_block_theme()`

 It also changes `wp_is_block_theme()` to be a helper wrapper (sugar
 syntax) for `wp_get_theme()->is_block_theme();`. Why? To ensure both the
 method and function behave the same, to help Gutenberg maintain WordPress
 cross-version compatibility, and to make it less cumbersome to port
 changes from Gutenberg to Core.

 Follow-up to [52069], [52247], [52279].

 Props antonvlasenko, costdev, hellofromTonya, noisysocks.
 Fixes #54550.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54550#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list