[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

[WordPress Trac]

#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.0
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early          |
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 [#comment:26 Replying to @azaozz]:
 >If it is under the "WordPress umbrella" it should follow the WordPress
 best practices, i.e. backwards compatibility is a number one priority.
 Frankly it is unthinkable that a library developed as part of WordPress
 would not only break back-compat, but will cause fatal errors when used in
 core...

 @azaozz Requests 2.0.0 is fully backwards-compatible and both @jrf and
 @schlessera made sure that was a priority.

 The fatal errors are not due to backwards compatibility, but rather are
 due to 2 issues identified in [#comment:22 my comment above]:

 * Detecting and handling case-insensitive filesystems
 * Preloading files into memory before upgrading the filesystem

 Requests 2.0.0 revealed both of these upgrader problems. However, Requests
 itself is not the source of the problems.

 Discovering that files must be preloaded means in 6.0 the upgrader can be
 made more robust and stable to ensure there's no co-mingling of "from" and
 "to" version code.

 Discovering the limitations of not detecting and handling files in case-
 insensitive filesystems means Core also could never change the case of an
 existing file. That's limiting. But in 6.0, the `Filesystem` and/or
 upgrader could enhanced to detect this and properly handle it.

 In talking with the Support team, there's a history of issues with the
 upgrade process which could be attributed to either of these upgrader
 issues and will be investigated. I'll also be doing a Trac search to
 identify other past tickets which might also be part of one or both of
 these issues.

 The discovery of these problems is good as it means the upgrader can be
 enhanced in 6.0.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform