[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

[WordPress Trac]

#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.0
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early          |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:19 schlessera]:
 > As @jrf already stated, Requests is still considered an external, third-
 party dependency

 If it is under the "WordPress umbrella" it should follow the WordPress
 best practices, i.e. backwards compatibility is a number one priority.
 Frankly it is unthinkable that a library developed as part of WordPress
 would not only break back-compat, but will cause fatal errors when used in
 core...

 > The correct way to name it according to the code style in place in the
 repository

 If there is such "code style" requirement in that repository it should be
 removed as incompatible with WordPress. Also, generally, namespaces should
 be considered "evil" in open source software and avoided as much as
 possible. The reason it that they promote "lazy" names that go against the
 best practice in writing good code (poor self-documenting, confusing
 names, etc.).

 Seems a possible/good way forward would be to release Requests 3.0 that
 will be incompatible with 2.0 but fully compatible with 1.0, then consider
 it for adding to the next WordPress release.  The alternative would be to
 move the Requests repository out of WordPress and continue developing it
 as a "true" third-party library that is, unfortunately, incompatible with
 WordPress.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform