[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

WordPress Trac noreply at wordpress.org
Mon Dec 6 16:01:50 UTC 2021

#54504: Update Requests library to version 2.0.0
 Reporter:  jrf                      |       Owner:  SergeyBiryukov
     Type:  task (blessed)           |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.9
Component:  External Libraries       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  php80 php81 needs-patch  |     Focuses:
Changes (by hellofromTonya):

 * keywords:  has-patch needs-dev-note php80 php81 => php80 php81 needs-
 * status:  closed => reopened
 * resolution:  fixed =>


 Reopening to revert Requests 2.0.0 and move introducing it to the 6.0.0
 cycle. Why?

 The namespace and file case renaming in Requests 2.0.0 revealed 2
 fundamental issues in the upgrader process:

 * Not all of the current "from" WordPress version code is preloaded into
 memory before the upgrader changes the filesystem. See #54546 and #54589.
 * The `Filesystem` does not identify or handle filename case changes on
 case-insensitive filesystems (see #54582 and #54547). This impacts Core
 and WP-CLI. It means on those systems the files are (a) not renamed and
 (b) are deleted when the old file removal deletes the files. The result is
 a fatal error.

 These issues are not due to Requests library, but rather are due to the
 issues above in the filesystem and upgrader.

 Reverting Requests back to its 5.8 version does not resolve the above
 issues but does restore back to 5.8 to avoid risky changes this late in
 the release cycle. Moving [52244] and [52315] along with the other tickets
 to 6.0 early gives breathing room and soak time for thoroughly
 investigating, refining, and multitiered testing.

 Marking for `needs-patch` for reverting both [52244] and [52315]/#54562.

 After the revert, then the milestone can be changed to 6.0 and marked as

Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list