[wp-trac] [WordPress Trac] #54546: Fatal error receive while updating WP 5.8.2 to WP 5.9.

WordPress Trac noreply at wordpress.org
Sat Dec 4 19:06:31 UTC 2021


#54546: Fatal error receive while updating WP 5.8.2 to WP 5.9.
--------------------------------------------+---------------------
 Reporter:  apeksha10                       |       Owner:  (none)
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  5.9
Component:  Upgrade/Install                 |     Version:  trunk
 Severity:  normal                          |  Resolution:
 Keywords:  needs-testing has-patch commit  |     Focuses:
--------------------------------------------+---------------------

Comment (by pbiron):

 Replying to [comment:35 hellofromTonya]:
 > @costdev @pbiron Should the cURL timeout value be increased to give more
 time to avoid the timeout error?

 I'm not sure that's necessary.  In most "real world" cases, when timeouts
 occur it's because there is a problem with the connection (or the remote
 server) and having an unduly long timeout just delays the inevitable
 timeout error :-)

 The default for the `wp_remote_{method}()` functions is 5 seconds
 (filterable by
 [https://developer.wordpress.org/reference/hooks/http_request_timeout/
 http_request_timeout], see
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-
 http.php#L161 L161, wp-includes/class-wp-http.php]), but various different
 calls to those functions throughout core often pass different timeout
 values in the `$options` param (e.g.,
 [https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/update.php#L157 wp_version_check()] uses 3 seconds).

 For me, that is too short, but that's just because my home internet
 connection is soooooo slow (satellite provider): average ping times for me
 are in the 600-900 ms range :-(.  So, on all the sites I run locally, I
 hook into `http_request_timeout` and add an extra 10 seconds.

 For those with normal connection speeds, I think the defaults currently
 used throughout core are fine...but certainly wouldn't object if others
 wanted to increase them.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54546#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list