[wp-trac] [WordPress Trac] #54261: KSES: Allow PDFs to be embeded as objects

WordPress Trac noreply at wordpress.org
Fri Dec 3 01:18:37 UTC 2021

#54261: KSES: Allow PDFs to be embeded as objects
 Reporter:  pento                                |       Owner:  pento
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Formatting                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |     Focuses:
  has-unit-tests needs-dev-note                  |

Comment (by peterwilsoncc):

 [https://github.com/WordPress/wordpress-develop/pull/1998 PR 1998] covers
 the port oversight causing the tests to fail on the Gutenberg repo, it
 also adds some tests to for sites running on a port.

 Props @ramonopoly


 Replying to [comment:15 ocean90]:
 > It's also odd that there seems to remain an empty `object` element.

 KSES can't match opening to closing tags (and to do so would be a major
 refactor) so following a discussion on the PR, it was decided the empty
 `object` tag was the best solution available.

 As this only becomes an issue if a user with `unfiltered_html` tries to
 mess with the input, I'm happy enough with that.

Ticket URL: <https://core.trac.wordpress.org/ticket/54261#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list