[wp-trac] [WordPress Trac] #54517: The naming of some of the WP_Theme_JSON_Resolver's methods is not optimal

WordPress Trac noreply at wordpress.org
Thu Dec 2 22:05:55 UTC 2021


#54517: The naming of some of the WP_Theme_JSON_Resolver's methods is not optimal
-------------------------------------+----------------------------
 Reporter:  antonvlasenko            |       Owner:  antonvlasenko
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.9
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  rest-api
-------------------------------------+----------------------------
Changes (by hellofromTonya):

 * keywords:  has-patch => has-patch needs-refresh
 * type:  enhancement => defect (bug)


Comment:

 Marking for refresh as there are merge conflicts in the PR.

 Also, 5.9 is in feature freeze meaning no enhancements can be merged.

 In this case, it's discussing the best name for a new public method in an
 existing API, new method introduced in 5.9. Reclassified this ticket to
 `defect` though that's not a great classification for it either.

 It's okay to discuss it now as once 5.9 final is released, the name has be
 maintained for backwards-compatibility.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54517#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list