[wp-trac] [WordPress Trac] #53945: Local test workflow changes for installing Composer dependencies
WordPress Trac
noreply at wordpress.org
Sun Aug 29 05:34:51 UTC 2021
#53945: Local test workflow changes for installing Composer dependencies
-------------------------------------------------+-------------------------
Reporter: hellofromTonya | Owner:
| johnbillion
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 5.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-testing-instructions | Focuses:
commit |
-------------------------------------------------+-------------------------
Changes (by netweb):
* status: closed => reopened
* resolution: fixed =>
Comment:
Replying to [comment:16 jrf]:
> Uh oh... commit [51685] has broken the tests from running against PHP
8.1....
Re-opening this issue...
> 1. Presuming the `install.js` script has access to the PHP version on
which the script is being run (does it ?), special case the command for
PHP 8.1 to use `--ignore-platform-requirements`.
We should be able to use wp-cli and the `wp-cli()` helper function to
check for that PHP version:
{{{
wp_cli( `eval 'echo PHP_VERSION;'` );
}}}
> 2. Presuming the `install.js` script has access to an environment
variable indicating that it is being run in the context of a GitHub
actions run, skip the call to `install_composer_dependencies()`.
Unure of what GitHub Actions environment variables are available to us
here
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53945#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list