[wp-trac] [WordPress Trac] #54032: Improve admin-bar style tag with CSS variables

WordPress Trac noreply at wordpress.org
Sat Aug 28 17:35:43 UTC 2021


#54032: Improve admin-bar style tag with CSS variables
-------------------------------------+-----------------------------
 Reporter:  TBschen                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  low                      |   Milestone:  Future Release
Component:  Toolbar                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch 2nd-opinion  |     Focuses:  css
-------------------------------------+-----------------------------
Changes (by sabernhardt):

 * keywords:  needs-patch => needs-patch 2nd-opinion
 * priority:  normal => low
 * version:  5.8 =>
 * component:  General => Toolbar
 * milestone:  Awaiting Review => Future Release


Comment:

 Thanks for the ticket!

 The `--wp-admin--admin-bar--height` custom property was just added for
 (newer) themes with ticket:52623.

 On that ticket, I discouraged putting the variable in the core style tag
 now because it affects the front end (IE support was dropped for the
 admin). Browser support is not quite as much of a concern if a core change
 would render the toolbar itself more difficult to use in certain old
 browsers. However, if the toolbar height variable defines that top margin,
 the top 32-46 pixels of a site could be unusable for some visitors when
 they log in.

 I'll leave this ticket open to consider that change later (unless closing
 as "maybe later" makes more sense).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54032#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list