[wp-trac] [WordPress Trac] #54029: Rename WordPress native expectDeprecated() and @ExpectedDeprecated to avoid confusion with PHPUnit native expectDeprecation and for future-proofing
WordPress Trac
noreply at wordpress.org
Fri Aug 27 20:38:09 UTC 2021
#54029: Rename WordPress native expectDeprecated() and @ExpectedDeprecated to avoid
confusion with PHPUnit native expectDeprecation and for future-proofing
------------------------------+------------------------------
Reporter: hellofromTonya | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
------------------------------+------------------------------
Comment (by SergeyBiryukov):
Thanks for the ticket!
Just noting that there are a few related methods in `WP_UnitTestCase_Base`
that we might want to consider when making any changes here for consistent
naming:
* `expectDeprecated()`
* `expectedDeprecated()`
* `setExpectedDeprecated()`
* `setExpectedIncorrectUsage()`
* `setExpectedException()`
* `deprecated_function_run()`
* `doing_it_wrong_run()`
On a slightly related note, I think `assertDiscardWhitespace()` should be
renamed to `assertEqualsDiscardWhitespace()`, for consistency with
`assertEqualsIgnoreEOL()`, but that's something for another ticket.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54029#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list