[wp-trac] [WordPress Trac] #53833: 'Replace image' Media Modal is missing select fields under filter media due to css issues

[WordPress Trac]

#53833: 'Replace image' Media Modal is missing select fields under filter media due
to css issues
-------------------------------------+----------------------------------
 Reporter:  mhuntdesign              |       Owner:  sabernhardt
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.8.1
Component:  Media                    |     Version:  5.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  css, administration
-------------------------------------+----------------------------------
Changes (by sabernhardt):

 * keywords:  needs-refresh => has-patch needs-testing


Comment:

 [attachment:"53833.more.patch"] tries to fix all three of these issues
 within the classic editor media modal. I would like at least the heading
 selector corrected in the minor release, as long as it does not make
 something else worse.

 If the `top` value adjustment is better than top padding, that change
 would fit in 5.8.1 as well (before anyone experiences it differently).

 The patch also involves reverting r44653, which goes back to WordPress
 5.1. Setting automatic width on the last `select` element makes it too
 wide at various smaller screen sizes when there are two of them. The Core
 changeset was intended as a first step, but then the code was never
 removed from the block editor styles. So the
 [https://github.com/WordPress/gutenberg/commit/8deaf5eca672848224e286e0ab03dde40fd5219d
 image block's fix] still operates in the block editor even with this
 patch.

 Additional considerations (likely better to revisit for a major release):

 - I think the [https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/css/media-views.css?rev=51631#L2834 82px height and top values]
 belong at the 900px breakpoint, where the filter selects and search box
 increase in font size and height. In the 783-900 pixel range, these
 elements can touch the top of selected image checkboxes and the focus
 outline can be clipped slightly.
 - The date filter can be too wide in the block editor as well as classic,
 when setting a Featured Image or using the Classic block. Theoretically,
 specifying `:first-of-type:last-of-type` together would make sure it only
 affects a single filter, but that selector is not pretty.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53833#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform