[wp-trac] [WordPress Trac] #42358: Twenty Seventeen: Social Links menu items in footer get hidden when used as child

WordPress Trac noreply at wordpress.org
Sat Aug 21 23:30:57 UTC 2021


#42358: Twenty Seventeen: Social Links menu items in footer get hidden when used as
child
-------------------------------------------------+-------------------------
 Reporter:  subrataemfluence                     |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots dev-feedback 2nd-    |     Focuses:  ui
  opinion                                        |
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  has-screenshots dev-feedback => has-screenshots dev-feedback
     2nd-opinion


Comment:

 Twenty Seventeen uses the `$depth` argument of 1 in `wp_nav_menu` for the
 Social Links Menu location. It only shows the top level so those links
 stay in one inline list. The same argument is used for social/secondary
 menu locations in each bundled theme from Twenty Fifteen to Twenty Twenty-
 One.

 If this is changed in (future) themes, it might require a new walker
 function.

 On the other hand, if someone accidentally puts a link at another level,
 some notification could help. The Menus screen and Customizer would need
 to check the depth argument and either show an error message or even try
 to correct it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42358#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list